chore: change funnel errors to ExposedHogQLError #24822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoob13
approved these changes
Sep 9, 2024
Twixes
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Why not the more general solution: replacing isinstance(err, ExposedHogQLError | ExposedCHQueryError) with isinstance(err, ExposedHogQLError | ExposedCHQueryError | APIException)? This would allow all ValidationErrors but also e.g. PermissionDenied to pass through, which should be the case, since these DRF exceptions are explicitly expose-able
Twixes
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Seems passing ValidationError through is the way – e.g. would automatically solve this issue: #24809 (comment)
aspicer
force-pushed
the
aspicer/funnel-errors
branch
from
0095a61 to
82263bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Realized through development environment that non posthog users couldn't see useful funnel errors (this was likely an async query change)
Changes
Change all validation errors in funnels to ExposedHogQLError
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Made sure errors surfaced when you weren't a staff user.